A common thing I noticed when I reviewed my classmates' code was that many of us had the same problems. Most people had trouble keeping track of the game state, like remembering guessed letters or keeping the score between rounds. Everyone did a good job building the basic Hangman game, but many struggled with the harder parts, like passing some unit tests or writing clean logic. I reviewed Erin Hurley’s and Mahmoud’s code. I looked at their GameLoader, Hangman, and their test classes. Their variable names were clear, and their logic worked well. I told them they might want to keep the score after each round and maybe make some big methods shorter to help with reading the code.
The feedback I got on my own code was very positive. Erin said my logic was efficient, especially the makeGuess method, and she liked how I commented my code. The only suggestion was to add my name and the date to the header. I think I still have things to fix in my code, like making the loop that handles guessed letters work better and checking inputs more carefully. The hardest part for me was passing most of the tests in HangmanTest, which tested if my game logic was correct and if it tracked the game state properly. The current tests work fine, but I think we could add more tests to check special situations like repeated guesses or wrong input.
From the reviews I did, I saw that the unit tests mostly check the basic parts of the game. If someone wrote subclasses, the tests may not check them completely. I wouldn’t change the current tests, but I would add more to make sure everything is covered. Reading and writing tests helped me understand what the code should do. I had trouble making sure guessed letters were saved and not guessed again. I think my teammates had similar problems. One part that was easy for me was getting back into Java. Even though it’s been a long time, it started to feel familiar again. In the end, I feel like HW1 was both hard and successful. I finished the game and passed all the tests, but I had to fix many bugs along the way. This assignment helped me learn how to write better code and how to understand other people’s code too.
Comments
Post a Comment